[Mplayer-cvslog] CVS: main configure,1.703,1.704

[Diego Biurrun]

Sascha Sommer writes:
 > > Alex Beregszaszi writes:
 > >  > Modified Files:
 > >  > configure
 > >  > Log Message:
 > >  > last cygwin/mingw32 binary codecs support (win32codecs + real) patch by
 > Sascha Sommer
 > >  >
 > >  > --- configure 11 May 2003 18:47:18 -0000 1.703
 > >  > +++ configure 11 May 2003 18:53:12 -0000 1.704
 > >  > @@ -4145,6 +4144,11 @@
 > >  >
 > >  >  if test "$_win32" != no ; then
 > >  >      if test -z "$_win32libdir" ; then
 > >  > +      if cygwin || mingw32 ; then
 > >  > +        _win32libdir="codecs"
 > >
 > > First of all this should also be done for _xanimlibdir, this patch is
 > > incomplete as it stands now.
 > 
 > Why do you need xanim codec on windows?
 > Afaik they have no advantages over the native dll ones.

For consistency's sake.  I must admit I haven't tested xanim codecs on
Windows yet.  I'll do that later today.

 > > Then I believe that Cygwin should behave like any other Unix port and
 > > not expect the codecs in ./codecs/, but in /usr/local/lib/codecs/.
 > 
 > Ok.

I'll change this later.

 > > For MinGW I'm not that strongly convinced, but I do not really see the
 > > necessity for the special case.  What's the default usage?  I think
 > > most people use MinGW like Cygwin and start MPlayer from a shell.  For
 > > binary redistribution it should not be a problem to compile with
 > > --with-win32libdir=codecs etc, so I vote to remove this entirely.
 > 
 > Hm. How many people are compiling mplayer on windows anyway?

Hmm, good question..  The two of us? ;-)

 > I think most people are only leeching the binarys...
 > Btw. I do not use mplayer from a shell. I have a link to mplayer.exe in
 > windows/sendto. This way there are no problems with other players
 > installed and you can still play every file without using the keyboard.

Let's compromise then.  I add a --with-codecsdir= option to configure
that you can then set to './codecs' and then I remove the special
cases for Cygwin and MinGW.

 > > I will gladly come up with a patch for this, we just need a consensus
 > > first.
 > >
 > > BTW, I think we are missing something like a --with-codecsdir= option
 > > for configure that allows setting all of the different codecs dirs at
 > > once.  If you agree this would be a good idea, I'll send in a patch.
 > 
 > I agree ;)

OK, coming up.

Diego