[Mplayer-cvslog] CVS: main/libmpcodecs vd_ffmpeg.c,1.108,1.109

[Michael Niedermayer]

Hi

On Monday 10 November 2003 00:56, Roberto Togni CVS wrote:
[...]
> +#if LIBAVCODEC_BUILD >= 4691
> +  if (pic->buffer_hints) {
> +    mp_msg(MSGT_DECVIDEO,MSGL_DBG2, "Buffer hints: %u\n",
> pic->buffer_hints); +    type = MP_IMGTYPE_TEMP;
> +    if (pic->buffer_hints & FF_BUFFER_HINTS_READABLE)
> +        flags |= MP_IMGFLAG_READABLE;
> +    if (pic->buffer_hints & FF_BUFFER_HINTS_PRESERVE) {
> +        type = MP_IMGTYPE_STATIC;
> +        flags |= MP_IMGFLAG_PRESERVE;
> +    }
> +    if (pic->buffer_hints & FF_BUFFER_HINTS_REUSABLE) {
> +        type = MP_IMGTYPE_STATIC;
> +        flags |= MP_IMGFLAG_PRESERVE;
> +    }
> +    flags|=(!avctx->hurry_up && ctx->do_slices) ?
> +            MP_IMGFLAG_DRAW_CALLBACK:0;
> +    mp_msg(MSGT_DECVIDEO,MSGL_DBG2, type == MP_IMGTYPE_STATIC ? "using
> STATIC\n" : "using TEMP\n"); 
> +  } else {
> +#endif
this will break if IP(B) style codecs set buffer_hints, which they dont 
currently, but they should

btw, i would prefer if we would add a reget_buffer() function instead of 
missuseing get_buffer() for CR buffers
the default reget_buffer() could simply reuse the buffer if its 
FF_BUFFER_TYPE_INTERNAL and call get_buffer(), memcpy(), release_buffer() if 
its FF_BUFFER_TYPE_USER
that would also avoid the cr_available negotiation and emulation in every 
codec if cr_available == 0

[...]
-- 
Michael
level[i]= get_vlc(); i+=get_vlc();		(violates patent EP0266049)
median(mv[y-1][x], mv[y][x-1], mv[y+1][x+1]);	(violates patent #5,905,535)
buf[i]= qp - buf[i-1];				(violates patent #?)
for more examples, see http://mplayerhq.hu/~michael/patent.html
stop it, see http://petition.eurolinux.org & http://petition.ffii.org/eubsa/en