[Mplayer-cvslog] CVS: main/libmpcodecs vf_yuvcsp.c,NONE,1.1 Makefile,1.114,1.115 vf.c,1.95,1.96

Arpi arpi at thot.banki.hu
Sun Nov 30 01:06:06 CET 2003


> Alex Beregszaszi writes:
>  > Added Files:
>  > 	vf_yuvcsp.c 
>  > Log Message:
>  > yuv colorspace converter
> Hmm, why did you call this 'yuvcsp' and not 'yuv'?  The other color
> space conversion filters are called yuy2 and yvu9.  The names should
> be consistent IMHO.

it's even worse.
this is not even a converter, it just clamps color values to a limited
range. so it should be called yuvclamp or just clamp.

or even better: implement it with a LUT (should be faster than doing 2
comparison for each color value per pixel) and then merge into vf_eq2

> Oh, I should probably also flame you for not writing docs ;-)

and I should flame about not writting it at least high-level optimal,
the per-pixel stride multiplication is so slow & lame...
but i already flamed alex down at irc :)

A'rpi / Astral & ESP-team

Developer of MPlayer G2, the Movie Framework for all - http://www.MPlayerHQ.hu

More information about the MPlayer-cvslog mailing list