[Mplayer-cvslog] CVS: main/libmpcodecs ad_liba52.c,1.10,1.11

Alex Beregszaszi alex at fsn.hu
Thu Oct 2 16:11:26 CEST 2003


Hi,

> if it isnt a vlid header, and it has to read one more byte, the
> header stuff will be swapped again, messing it all up.
Just reread the code, and it is braindamaged imho, swipswapping all the
times the 64bit sync tag, but only for original AC3 and not for Real's
DNET. Also later in a52_printinfo it calls a52_syncinfo without
byteswapping...
 
> insteda of swapping the header in the buffer, liba52 should be fixed,
> to handle header parsing correctly on bigendian systems.
> but again: imho it worked well, no fix needed.

-- 
Alex Beregszaszi <alex at fsn.hu>
(MPlayer Core Developer -- http://www.mplayerhq.hu/)



More information about the MPlayer-cvslog mailing list