[Mplayer-cvslog] CVS: main/libmpcodecs vf_hue.c,NONE,1.1 Makefile,1.110,1.111 vf.c,1.93,1.94

[Michael Niedermayer]

Hi

On Thursday 23 October 2003 22:01, D Richard Felker III wrote:
> On Thu, Oct 23, 2003 at 08:36:33PM +0200, Michael Niedermayer CVS wrote:
> > Update of /cvsroot/mplayer/main/libmpcodecs
> > In directory mail:/var/tmp.root/cvs-serv24470
> >
> > Modified Files:
> > 	Makefile vf.c
> > Added Files:
> > 	vf_hue.c
> > Log Message:
> > vf_hue
>
> Michael, could you remove this and just add the code to vf_eq/eq2? IMO
> it's silly to have it split into two separate filters like this.
yes, its silly, i agree, ideally we should have a single eq filter which 
selects the best code to accomplish the filtering given the parameters, the 
reason why it ended up as its own filter was that eq doesnt touch chroma, i 
faintly remember someone saying that it shouldnt mess with chroma as the user 
might mistakely slighly change the saturation and that would cause a slowdown 
or so, and eq2 is LUT based which doesnt fit very well together with hue 
adjustment (we would need to do gamma and the hue seperately, and in what 
order should they be done?
and anyway eq2 gamma is broken as we know, it should be done in RGB space, but 
if eq2 would be fixed and run in RGB space then how should hue adjustment be 
done? IMHO gamma and hue should not be in the same filter, it causes too many 
problems

[...]
-- 
Michael
level[i]= get_vlc(); i+=get_vlc();		(violates patent EP0266049)
median(mv[y-1][x], mv[y][x-1], mv[y+1][x+1]);	(violates patent #5,905,535)
buf[i]= qp - buf[i-1];				(violates patent #?)
for more examples, see http://mplayerhq.hu/~michael/patent.html
stop it, see http://petition.eurolinux.org & http://petition.ffii.org/eubsa/en