[Mplayer-cvslog] CVS: main/libmpcodecs vf_fil.c,NONE,1.1 Makefile,1.109,1.110 vf.c,1.92,1.93

[Michael Niedermayer]

Hi

On Thursday 23 October 2003 23:09, D Richard Felker III wrote:
> On Thu, Oct 23, 2003 at 10:41:41PM +0200, Michael Niedermayer wrote:
> > Hi
> >
> > On Thursday 23 October 2003 22:05, D Richard Felker III wrote:
> > > On Wed, Oct 22, 2003 at 11:22:29PM +0200, Michael Niedermayer CVS wrote:
> > > > Update of /cvsroot/mplayer/main/libmpcodecs
> > > > In directory mail:/var/tmp.root/cvs-serv14387
> > > >
> > > > Modified Files:
> > > > 	Makefile vf.c
> > > > Added Files:
> > > > 	vf_fil.c
> > > > Log Message:
> > > > fast deinterleaver (= il filter with stride/width/height tricks)
> > >
> > > Huh? This code looks totally broken.
> >
> > yes, its not strictly correct, (it needs to know the stride during
> > config() ...)
>
> Hmm, ...
>
> Could we just wait to call config until the first put_image? Is this
> valid?
even if, it doesnt fully solve the problem
for -vf fil we need to know the stride, so that width is large enough to cover 
both lines, but for -vf fil=i we need to reverse this so we need to know 
where the second line starts (and the image may have been scaled inbetween)
the current code only sometimes works ...

[...]
-- 
Michael
level[i]= get_vlc(); i+=get_vlc();		(violates patent EP0266049)
median(mv[y-1][x], mv[y][x-1], mv[y+1][x+1]);	(violates patent #5,905,535)
buf[i]= qp - buf[i-1];				(violates patent #?)
for more examples, see http://mplayerhq.hu/~michael/patent.html
stop it, see http://petition.eurolinux.org & http://petition.ffii.org/eubsa/en