[Mplayer-cvslog] CVS: main/libmpdemux open.c,1.89,1.90

[Alex Beregszaszi]

Hi,

> > @@ -478,6 +478,7 @@
> >    // FIXME: to avoid nonsense error messages...
> >    if (strncmp("tv://", filename, 5) && strncmp("mf://", filename,
> >    5) &&
> >      strncmp("vcd://", filename, 6) && strncmp("dvb://", filename,
> >      6) &&
> > +    strncmp("cdda://", filename, 7) && strncmp("cddb://", filename,
> > 7) &&
> >      strstr(filename, "://"))
> 
> What about dvd?? IMO this is dumb -- url_read should just accept the
> (very few) prefixes that are valid urls, and silently ignore the rest,
> so we don't have to keep adding tests like this...
dvd:// cue:// smb:// are handled above the code

The whole stuff is dumb.. url_open complains if it gets a bad url.
Imho it doesn't make sense where to add the check.

-- 
Alex Beregszaszi <alex at fsn.hu>
(MPlayer Core Developer -- http://www.mplayerhq.hu/)