[Mplayer-cvslog] CVS: main/libvo vo_svga.c,1.68,1.69

[Ivan Kalvachev]

D Richard Felker III said:
> On Mon, Sep 22, 2003 at 10:15:35AM +0200, Attila Kinali wrote:
>> On Mon, 22 Sep 2003 02:00:17 +0200
>> Ivan Kalvachev CVS <iive at mplayerhq.hu> wrote:
>> > Modified Files:
>> > 	vo_svga.c
>> > Log Message:
>> > blackbar osd support based on patch send by Dimitar Zhekov
>> <jimmy at is-vn.bg>,
>> > page code removed/merged, small updates
>> I thought this patch was rejected because it's useless as -vf expand does
>> the same job in a vo independent manner ?
>
> Agree, reverse such hackish nonsense.
>
> Rich
>
The last latter in the thread is mine and i warn that i will commit that
into the svga, nobody say don't so 2 days later i did it.
Won't revert.

It is not nosense, the bigges disadvantage of expand it that you should
point explictly the height to get full screen OSD. this mean that you
should
run the file once, and then calculate the height based on aspect and
width, and
run it twice to watch it. I don't want to use scale if there is no need to!

Anyway, i had it in the todo, and it also fix another bug, when
image_width < modeinfo->width (oops i forgot to fix that one)

Many users want subtitles in the black bars, they want it fox xv. they are
these
kind of users that donno what video filter is and .... well sdl do it, why
not the others?

Best Regards
   Ivan Kalvachev
 iive

p.s. As i say in the last mail of the thread, this is only quick hack,
there should
be vo_remove_text to remove the subtitles. can vf_expand clear buffers he
doesn't own anymore (-double)? (iive's todo: test expand with -double;)