[Mplayer-cvslog] CVS: main/libvo vo_svga.c,1.68,1.69

[D Richard Felker III]

On Tue, Sep 23, 2003 at 02:57:39PM +0200, Alban Bedel wrote:
> > > It is not nosense, the bigges disadvantage of expand it that you
> > > should point explictly the height to get full screen OSD. this mean
> > > that you should
> > > run the file once, and then calculate the height based on aspect and
> > > width, and
> > > run it twice to watch it. I don't want to use scale if there is no
> > > need to!
> > 
> > Then add an option to expand to auto-select output aspect ratio, i.e.
> > add sufficient borders so that the output is 4:3 (or whatever the user
> > selects).
> I thought abut this too. But it should rather use monitor_aspect instead
> of 4/3 and take care of the prescaled size.  Ok all the aspect stuff
> won't be that simple but that seems to be the solution.

4:3 was just an example; I said to use what the user requests.
Directly using monitoraspect could be bad:

1) mencoder has no monitoraspect.

2) Filters are not supposed to depend on outside global vars!!!!!!!!!!

3) The user could have other filters after expand, making it incorrect
   to just assume desired output aspect = monitor aspect.

Rich