[Mplayer-cvslog] CVS: main/libvo vo_svga.c,1.68,1.69

[D Richard Felker III]

On Tue, Sep 23, 2003 at 05:00:13PM +0200, Alban Bedel wrote:
> Hi D Richard Felker III,
> 
> on Tue, 23 Sep 2003 10:17:30 -0400 you wrote:
> 
> > On Tue, Sep 23, 2003 at 02:57:39PM +0200, Alban Bedel wrote:
> > > > > It is not nosense, the bigges disadvantage of expand it that you
> > > > > should point explictly the height to get full screen OSD. this
> > > > > mean that you should
> > > > > run the file once, and then calculate the height based on aspect
> > > > > and width, and
> > > > > run it twice to watch it. I don't want to use scale if there is no
> > > > > need to!
> > > > 
> > > > Then add an option to expand to auto-select output aspect ratio,
> > > > i.e. add sufficient borders so that the output is 4:3 (or whatever
> > > > the user selects).
> > > I thought abut this too. But it should rather use monitor_aspect
> > > instead of 4/3 and take care of the prescaled size.  Ok all the aspect
> > > stuff won't be that simple but that seems to be the solution.
> > 
> > 4:3 was just an example; I said to use what the user requests.
> > Directly using monitoraspect could be bad:
> > 
> > 1) mencoder has no monitoraspect.
> yes, but for mplayer it's seems to me like the best default for such mode.

My point was that mencoder would fail to link unless we did some
horrible hack like including an unused monitoraspect variable in
mencoder.c...

> > 2) Filters are not supposed to depend on outside global vars!!!!!!!!!!
> yes, by principe you'r right. In practice with mplayer it's not always
> possible (no, i don't absolutly want to use monitoraspect).
> 
> > 3) The user could have other filters after expand, making it incorrect
> >    to just assume desired output aspect = monitor aspect.
> Again you are right, however i still think that monitoraspect is a better
> default than 4/3.

IMO there should be no default if a good default can't be selected. If
we're talking about adding features to the existing expand filter, it
should just have a way to specify aspect (e.g. expand=a/b rather than
expand=w:h:x:y) and then the default (like right now) is not to expand
at all.

Rich