[Mplayer-cvslog] CVS: main/liba52 parse.c,1.5,1.6

[Arpi]

Hi,

> > +#if defined(__MINGW32__) && defined(HAVE_SSE) 
> > +    for(i=0;i<10;i++){
> > +      if((int)samples%16){
> > +        sample_t* samplestmp=malloc(256 * 12 * sizeof (sample_t));   
> > +        free(samples);
> > +        samples = samplestmp;    
> > +      }
> > +      else break;
> > +    }

uhh, this is fuckin ugly hack

> > +    if((int)samples%16){
> > +      printf("unable to get 16 bit aligned memory => expect crashes
> when using SSE instructions\n");
> > +    }
> > +#endif

and this is unacceptable
at least disable sse support in this case, insteda of expecting crash

> memalign(2,...) doesn't work? Because that's what you should use to get 16
> _bit_ (==2 byte) aligned memory. Besides, according to the manpage:
> 
> "GNU libc malloc() always returns 8-byte aligned memory addresses, so
> these routines are only needed if you require larger alignment values."

it's for win32/mingw stuff, where no glibc nor memalign() at all.


A'rpi / MPlayer, Astral & ESP-team

--
PyMaViS - my answer to worm storm - http://mplayerhq.hu/~arpi/pymavis/