[Mplayer-cvslog] main/libvo vo_quartz.c,1.1,1.2

Fabian Franz FabianFranz at gmx.de
Mon Apr 26 20:48:21 CEST 2004

Am Montag, 26. April 2004 15:48 schrieb Nicolas Plourde:
> Just to be clear, I know there like 2 cosmetic change in this
> patch but the previous file was like 3 month old and only
> applied 2 weeks ago by Alex. Its hard to keep my stuff up to  date
> at this rhythm and wait for every patch I submit to be committed.


the problem is that cosmetic changes are not allowed. That is the policy.

I know its hard to remove those cosmetic changes, but a CVS account should be 
worth that bit. I hope you are reading the CVS-Log Mailinglist, which every 
developer should do that has CVS-access. 

Alex did write on the CVS-Log ML that he reversed your patch due to the 
cosmetic changes. That was kind of a warning. But as you just recommited the 
same code (as far as I can see) with the same cosmetic changes, Arpi disabled 
the account.

Well everyone can make mistakes and I hope that you understand why we have 
this policy, that you subscribe to mplayer-cvs-log asap and then are granted 
CVS access again and stick to the policy.

Policy also is not for bad will, but because its needed. 
What is even harder than sticking to a policy is to read and use 
diff-revisions, which have many cosmetic changes. So the policy was created. 
Revisions often helped in finding errors or just 10ls ;-) (you have to drink 
10l of Cola, which should help you to concentrate more and so you make no 
mistakes. That at least is the theory behind it)

I hope you can "cool" down a bit. We all made mistakes and the Hungarians are 
known for being a bit ... Well I'll stop now ;-)

(Well, I remember sending one patch again and again, because it was not  good 
in the eyes of Arpi (and other devs). I learned a lot from it. Btw.: Thank 
you, Arpi)




More information about the MPlayer-cvslog mailing list