[Mplayer-cvslog] CVS: main ChangeLog,1.101,1.102

[The Wanderer]

Diego Biurrun CVS wrote:

> CVS change done by Diego Biurrun CVS
> 
> Update of /cvsroot/mplayer/main
> In directory mail:/var2/tmp/cvs-serv15715
> 
> Modified Files:
> 	ChangeLog 
> Log Message:
> The eve of a new release is always a good time to take history lessons, so
> I read the changelog in an editor...

> Index: ChangeLog
> ===================================================================
> RCS file: /cvsroot/mplayer/main/ChangeLog,v
> retrieving revision 1.101
> retrieving revision 1.102
> diff -u -r1.101 -r1.102
> --- ChangeLog	26 Apr 2004 14:41:43 -0000	1.101
> +++ ChangeLog	26 Apr 2004 19:41:22 -0000	1.102

> @@ -145,7 +145,7 @@
>      * many H264 improvements
>      * more robust MJPEG startcode search mechanism
>      * better WMV8 decoding
> -    * native SPARC VIS optimizations
> +    * native Sparc VIS optimizations

As I understand it, "SPARC" is in fact an acronym, VERA lists it as 
"Scalable Processor ARChitecture". Unless this line actually refers to 
something else I'm missing, the all-caps form would be the appropriate one.

(I thought it stood for "Sun Palo Alto Research Center", but oh well...)

> @@ -338,12 +338,15 @@
>  
>      Ports:
>      * initial Amiga/MorphOS (through GeekGadgets) support
> -    * FreeBSD 5.x (libkse/libthr) support in win32 DLL loader
> -    * finally fixed the compilation on non-mvi capable alpha CPUs
> -    * better altivec detection in configure
> +    * FreeBSD 5.x (libkse/libthr) support in Win32 DLL loader
> +    * finally fixed the compilation on non-mvi capable Alpha CPUs
> +    * better AltiVec detection in configure
>      * OSD menu now works on MinGW
>      * slave mode, vobsub and MEncoder support on Windows
>      * MinGW 3.1.0 supports MPlayer out of the box!

Isn't "MVI" an acronym?

> @@ -538,15 +538,15 @@
>  
>      Others:
>      * gcc can now detect badly called mp_msg()s
> -    * a lot of config/cmdline parsing fixes (some of them were at least 100000l bugs)
> +    * manyconfig/cmdline parsing fixes (some of them were at least 100000l bugs)
>      * configure: enable VIDIX for PPC

Typo - omitted space after "many".

<skip about four arguable and/or minor notes>

> +MPlayer v0.11-pre25-CVS:  yeah, we moved to SourceForge CVS!
>    - DOCS updated (email address changed from arpi@* -> maillist)
>    - LIRC fix, mplayer_lirc changed back to mplayer [Andreas Ackermann]
>    - stream.c: unsigned int fixes, required for some strange ASF files
>    - asfheader.c: using w=h=b=1 for audio_concealment_none
> -  - VCD-related stuff moved from stream.c to vcd_read.c
> +  - VCD related stuff moved from stream.c to vcd_read.c

This is incorrect - the hyphen belongs there.

> +MPlayer v0.11-pre21: Feb 12, 2001
>    MPEG1 pp, stereo fix
>    - "Skip chunk xxxx" messages moved from -v to -v -v -v debug level...
>      [thanks to Christoph H. Lampert]
> -  - DivX postprocess filter works for MPEG1 files too! (-divxq 1/3/7/31)
> +      - DivX postprocess filter works for MPEG1 files, too! (-divxq 1/3/7/31)

Why the additional indentation?

>    - MPEG layer-2 audio fixed - it's stereo again!!!
>    - audio select() detection: if detected audio buffer size == 0, then
> -    exit with message "recompile mplayer with #undef HAVE_AUDIO_SELECT"...
> +    exit with message "recompile MPlayer with #undef HAVE_AUDIO_SELECT"...

This change is correct only if that is the exact message output, or if
the described message no longer occurs.


As noted, there were about four more arguable and/or less important
things I noticed but didn't mention; I don't want to get too nitpicky
and annoying, though it may be too late to worry about that.

(Hey, even if I don't understand most of the actual code, maybe I can at
least contribute by going over things like this....)

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

A government exists to serve its citizens, not to control them.