[Mplayer-cvslog] CVS: main mencoder.c, 1.251, 1.252 mp_msg.h, 1.29, 1.30 mplayer.c, 1.774, 1.775

[The Wanderer]

Roberto Togni wrote:

> On 2004.08.24 21:36, Diego Biurrun CVS wrote:

>> Index: mencoder.c
>>    if(!filename){
>> -    printf(MSGTR_MissingFilename);
>> +    mp_msg(MSGT_FIXME, MSGL_FIXME, MSGTR_MissingFilename);
>>      mencoder_exit(1,NULL);
>>    }
> 
> I think that everything that is followed by an exit can be placed in
> class MSGL_ERR or MSGL_FATAL, they are both used for this purpose in
> other places in the file (see below).
> If the program terminates because of the error probably fatal is
> better.

Actually, it occurs to me to wonder: since the second argument to
mencoder_exit is a string to be printed, why does this print a message
itself and then make a call to mencoder_exit with a null string? It
would seem to make more sense to just pass the desired string to
mencoder_exit directly.

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

A government exists to serve its citizens, not to control them.