[Mplayer-cvslog] CVS: main/libvo x11_common.c,1.176,1.177

Alexander Strasser eclipse7 at gmx.net
Wed Aug 25 16:22:10 CEST 2004


On Mon, Aug 23, 2004 at 11:36:51AM +0200, Jindrich Makovicka CVS wrote:
> Log Message:
> don't mess with the window after setting EWMH_FULLSCREEN (needed for fvwm)

> Index: x11_common.c
> ===================================================================
> RCS file: /cvsroot/mplayer/main/libvo/x11_common.c,v
> retrieving revision 1.176
> retrieving revision 1.177
> diff -u -r1.176 -r1.177
> --- x11_common.c	8 Aug 2004 23:22:04 -0000	1.176
> +++ x11_common.c	23 Aug 2004 09:36:49 -0000	1.177
> @@ -1466,13 +1466,13 @@
>              vo_x11_setlayer(mDisplay, vo_window, vo_ontop);
>  
>          XMoveResizeWindow(mDisplay, vo_window, x, y, w, h);
> -    }
>  #ifdef HAVE_XINERAMA
> -    vo_x11_xinerama_move(mDisplay, vo_window);
> +	vo_x11_xinerama_move(mDisplay, vo_window);
>  #endif
>  
> -    XMapRaised(mDisplay, vo_window);
> -    XRaiseWindow(mDisplay, vo_window);
> +	XMapRaised(mDisplay, vo_window);
> +	XRaiseWindow(mDisplay, vo_window);
> +    }
>      XFlush(mDisplay);
>  }

Seems that most of the changes are cosmetic in an unwanted way...
The file was just reindented by attila and this breaks the gained consistency...
Anyway we still have strict cosmetics policy...
...

I'll maybe revert it.
Please don't just commit into X11 code, especially not fullscreen code.
Let me know about the changes you propose and I'll review them and test
with many WMs.

  Alex (beastd)




More information about the MPlayer-cvslog mailing list