[MPlayer-cvslog] CVS: main/libaf af_mp.c,1.7,1.8

Ivo ivop at euronet.nl
Mon Dec 20 03:27:00 CET 2004

On Sunday 19 December 2004 23:35, Reimar Döffinger wrote:
> Hi,
> > -    if((fmt->format&AF_FORMAT_POINT_MASK)==AF_FORMAT_I){
> > +    if(fmt->format&AF_FORMAT_I){
> I think actually that's just because AF_FORMAT_POINT_MASK is defined
> incorrectly. But I can't test at the moment.
> Can somebody fix or revert? (as broken as it seems to be that might be
> better).

Yep, according to this:

// Fixed or floating point
#define AF_FORMAT_I     0x8 // Int
#define AF_FORMAT_F     0x10 // Foating point
#define AF_FORMAT_SPECIAL   0x20 // Must be set if below values used
#define AF_FORMAT_POINT_MASK    0xf0

AF_FORMAT_POINT_MASK should be at least 0x38 and most probably 0xf8.

How should I proceed? I'm a little hesitant to just commit a patch, because 
I'm not sure about whether to revert first (reverts other changes too) or 
just commit a fix.


More information about the MPlayer-cvslog mailing list