[MPlayer-cvslog] CVS: main/libvo vo_directx.c,1.42,1.43

[D Richard Felker III]

On Thu, Dec 23, 2004 at 02:23:50PM -0600, Joey Parrish wrote:
> On Tue, Dec 21, 2004 at 05:04:50PM -0500, D Richard Felker III wrote:
> > On Tue, Dec 21, 2004 at 09:32:29PM +0100, Joey Parrish CVS wrote:
> > > 	vo_directx.c 
> > > Log Message:
> > > automatic monitoraspect calculation for vo_directx.
> 
> > >      vo_screenwidth = monitor_rect.right - monitor_rect.left;
> > >      vo_screenheight = monitor_rect.bottom - monitor_rect.top;
> > > +    monitor_aspect = (float)vo_screenwidth / (float)vo_screenheight;
> 
> > THIS IS BLATENTLY WRONG!!! REVERSE!!!
> > 
> > Aspect is PHYSICAL size, not size in pixels!!!!!
> > i.e. 1280x1024 is not 4:3 pixels but is 4:3 monitor_aspect!!!
> > Rich
> 
> How is this different from this line in vo_quartz?
> 
>   monitor_aspect = (float)device_width/(float)device_height;

these are (presumably) the _physical_ dimensions of the display, which
do determine monitor aspect. vo_screenwidth/height on the other hand,
are the _pixel_ dimensions, which have absolutely no relation to
aspect.

rich