[MPlayer-cvslog] CVS: main/libaf af_ladspa.c, NONE, 1.1 .cvsignore, 1.1, 1.2 Makefile, 1.18, 1.19 af.c, 1.34, 1.35

[Felix Buenemann]

On Saturday 25 December 2004 01:09, D Richard Felker III wrote:
> On Fri, Dec 24, 2004 at 11:47:36PM +0100, Reimar Döffinger wrote:
> > >
> > > FLOAT SAMPLE FORMAT DOES NOT WORK!!!!!!!!!
> > >
> > > It will load 20 different random conversion filters between formats
> > > that don't even exist, like "8bit unsigned float", use 50% cpu, and
> > > output white noise in the end!
> >
> > Are you sure? If so don't you think it would be better to fix it instead
> > of duplicating code?
>
> Yes. It seems to work for some people, but not others. I expect
> uninitialized variables or other broken code that's causing random
> behavior that works with some cpus or compiler versions and not
> others..
Hmm, like missing EMMS after MMX code?

> Anyway fixing it would be good, but removing float nonsense would be
> much better.
agree, it made audio processinbg in mplayer much slower cause it does useless 
conversion 16bit int -> float -> 16bit int.

> > > All filters should (IMNSHO _MUST_) operate internally on integer
> > > samples, simply because float is unusably slow on many platforms (even
> > > if float format is fixed).
> >
> > Tell use how this should be possible in this case and I'm sure it will
> > be done. I think we all know the problems with floating point, as well
> > as your opinion on it...
>
> Just modify the code to use int samples...?
>
> Rich

-- 
Best Regards,
        Atmos
____________________________________________
- MPlayer Developer - http://mplayerhq.hu/ -
____________________________________________