[MPlayer-cvslog] CVS: main/libaf af.c,1.35,1.36

[Ivan Kalvachev]

On Sun, 26 Dec 2004 15:24:46 +0100
Felix Buenemann <atmosfear at users.sourceforge.net> wrote:

> On Sunday 26 December 2004 15:14, Reimar D_ffinger wrote:
> > Hi,
> >
> > > > CVS change done by Reimar D_ffinger CVS
> > > >
> > > > Update of /cvsroot/mplayer/main/libaf
> > > > In directory mail:/var2/tmp/cvs-serv8321/libaf
> > > >
> > > > Modified Files:
> > > >  af.c
> > > > Log Message:
> > > > Use lavcresample when accuracy-optimized audio filter chain is
> > > > requested.
> > >
> > > shouldn't it be dependant on wether lavc is compiled in?
> >
> > Yes, you are right... Actually on thinking once again it was quite a
> > stupid patch. What do you think about the attached one?
> Hmm, I'm not sure, are there any advantages for the lavcresampler, IIRC the 
> mplayer one was pretty good, but is lavc one faster?
> 
> > Greetings,
> > Reimar D_ffinger
> -- 
> Best Regards,
>         Atmos
The committed code tries to insert lavcresampler and if it fails 
(e.g. doesn't exist) reverts to resample.
I think that the forced behavior could be improved a little (without adding one
more option ;) I guess #ifdef could be appropriate;

JFYI resampler is lowering the volume, in speed mode mangles some frequencies
and speed mode is the default. There was quite long thread about it in -dev-eng.
lavcresampler is superior to af_resample in every aspect (including quality).

Wish You Best
   Ivan Kalvachev
 iive