[Mplayer-cvslog] CVS: main/libmpcodecs vd_ffmpeg.c,1.115,1.116

[Michael Niedermayer]

Hi

On Friday 02 January 2004 01:11, D Richard Felker III wrote:
> On Thu, Jan 01, 2004 at 07:51:46PM +0100, Michael Niedermayer wrote:
> > Hi
> >
> > On Thursday 01 January 2004 19:18, D Richard Felker III wrote:
> > > On Thu, Jan 01, 2004 at 04:56:03PM +0100, Michael Niedermayer CVS wrote:
> > > > Update of /cvsroot/mplayer/main/libmpcodecs
> > > > In directory mail:/tmp/cvs-serv24429
> > > >
> > > > Modified Files:
> > > > 	vd_ffmpeg.c
> > > > Log Message:
> > > > disable slices & dr1 if motion vector vissualization is used, still
> > > > doesnt work though, maybe i should reverse the last mv vis patch ...
> > >
> > > IMO yes. MV vis should be a separate filter using the exported mv's.
> >
> > yes it should be, but that would make it more difficult to use for
> > everyone who uses libavcodec in their applications ...
>
> Well the same could be said about software-scaling (hey, we _need_ a
> scaler to convert 480x480 svcd to square pixels!) or postprocessing or
> denoising or inverse telecine or ...
>
> My point is that yes, there are a lot of features that would be
> beneficial for all players to have, but putting them all in lavc
> doesn't make sense. It's just bloat....and when you step over the
> bounds of just bloat and into the bounds of "buggy bloat" (like this
> mv visualization stuff), it's bad IMHO...
yes, i fully agree, i would be very happy if someone would send me a patch 
which moves the mv vissualization out of libavcodec, and indeed i suggested 
this to the guy who sended me all these mv vissualization patches before he 
wrote them but he ignored me, so i just had the choice of applying the 
patches which fixed and cleaned up various related parts, or to reject them 
but that wouldnt have made the code any less buggy & bloated, anyway, before 
his patches we didnt even export the motion vectors...

btw, will the VP stuff be easily useable by other applications? maybe renaming 
it it libavfilter would be an option too (under GPL of course) :)))))))

[...]
-- 
Michael
level[i]= get_vlc(); i+=get_vlc();		(violates patent EP0266049)
median(mv[y-1][x], mv[y][x-1], mv[y+1][x+1]);	(violates patent #5,905,535)
buf[i]= qp - buf[i-1];				(violates patent #?)
for more examples, see http://mplayerhq.hu/~michael/patent.html
stop it, see http://petition.eurolinux.org & http://petition.ffii.org/eubsa/en