[Mplayer-cvslog] CVS: main/libvo vo_cvidix.c,1.7,1.8

[D Richard Felker III]

On Thu, Jul 08, 2004 at 12:10:45AM +0300, Ivan Kalvachev wrote:
> D Richard Felker III said:
> > On Tue, Jul 06, 2004 at 10:05:12PM +0200, Sascha Sommer wrote:
> >> > OK, feel free to make these changes. But the default should (IMO) be
> >> > centered and the color key should not be enabled since it makes the
> >> > movie invisible!
> >> >
> >>
> >> Centered is no problem, but I don't know how to make nocolorkey default
> >> without removing the ability to optionally use colorkeying
> >> as -nocolorkey and colorkey use the same config variable.
> >> After all vo cvidix is stil a dumb driver.
> >
> > How does colorkey support make sense at all for a vo driver that
> > doesn't have a window and that can't paint the colorkey?? IMO it's
> > nonsense...
> 
> All text mode are acutally graphic modes where pixels are calculated at
> runtime by hardware. It include reading ROM/RAM charsets that indicate
> foreground/backround color. The actuall index of the color is defined by
> additional (char) byte, and the color is index in palette.
> 
> If you need more background information I recomend you SVGATextMode
> documentation. This project brings custom modelines in text mode,
> including custom modes.

This is all nice but irrelevant. The point is that the cvidix vo
driver has no access to the contents of the display, only the overlay
buffers. So it can't paint a color key on. Use of color key only makes
sense when the vo driver can write to both the overlay and the main
video memory to draw a rectangle with the color key.

Rich