[Mplayer-cvslog] CVS: main cfg-mplayer.h,1.220,1.221

Diego Biurrun diego at biurrun.de
Tue Jul 20 13:02:28 CEST 2004


On Sat, Jul 17, 2004 at 08:59:02PM +0900, attila wrote:
> On Mon, Jun 28, 2004 at 02:17:38PM +0200, Diego Biurrun CVS wrote:
> > CVS change done by Diego Biurrun CVS
> > 
> > -        {"rtc", &rtc_device, CONF_TYPE_STRING, 0, 0, 0, NULL},
> > +	{"rtc", &nortc, CONF_TYPE_FLAG, 0, 0, 0, NULL},
> 
> I'm not quite sure anymore, but i thougt that XX and noXX options
> should have the min/max values exchanged, or am i wrong ?
> (prolly, as it been a while since i hacked cfg-*.h)

Maybe it makes more sense when you see the whole block with a bit of
prettyprinting added:

  {"nortc", &nortc, CONF_TYPE_FLAG, 0, 0, 1, NULL},
  {"rtc",   &nortc, CONF_TYPE_FLAG, 0, 0, 0, NULL},
  {"rtc-device", &rtc_device, CONF_TYPE_STRING, 0, 0, 0, NULL},

I think it's correct.

> BTW: unless i am blind, there is no docu about this, but
> this is one of the parts nearly everyone needs to edit
> if he/she wants to add a new option.
> Could someone with knowledge about the config system
> write a short text for DOCS/tech ?

Good idea.  Any volunteers?

Diego




More information about the MPlayer-cvslog mailing list