[Mplayer-cvslog] CVS: main/DOCS/tech patches.txt,1.20,1.21

[The Wanderer]

Diego Biurrun CVS wrote:


>   4. Read your patch. We'll *refuse* it if it changes indentation of the
>      code or if it does tab/space conversion or other cosmetical changes!

"changes the indentation", or "changes indentation of code" - I think.
Also, "cosmetical" isn't a word AFAIK. The Collaborative International
Dictionary of English lists it as an alternate form of "cosmetic", but
I've certainly never heard it before.

> +    Try to avoid uploading the patch to a web or FTP site, send it directly
> +    to the mailing list. The less steps it takes us to get at the patch the
> +    higher the likelihood for it to get reviewed and applied. If your patch
> +    is so big you cannot send it by mail, try splitting it into pieces.

"less" -> "fewer". (This is the same as the grocery-store express-lane
"ten items or less" error... very common, but incorrect.)

> - 8. Give us a few days to react. We try to review patches as fast as possible,
> + 9. Give us a few days to react. We try to review patches as fast as possible,
>      but unfortunately we are constantly overloaded with work, be it MPlayer
>      related or from our day to day lives. If your patch seems to be ignored,

"MPlayer-related", with linebreak after the hyphen if necessary.

> - 9. Do not immediately ask for CVS write access. If you contributed one or
> +10. Do not immediately ask for CVS write access. If you contributed one or
>      more nice, acceptable patches and they need maintaining or you want to
>      be an MPlayer developer, you'll get CVS write access.

Tense inconsistency between "contributed" (past), "need" (present)" and
"you'll" (future). The latter two can work together in their current
forms, because of the particular context, but the past-tense form is out
of place. The simplest solution is to change it to "have contributed".

> -10. For consistency reasons all option names must use '-' instead of '_'.
> +11. For consistency reasons all option names must use '-' instead of '_'.
>  
> -11. If you made a nontrivial contribution and wish to be mentioned in the
> +12. If you made a nontrivial contribution and wish to be mentioned in the
>      AUTHORS file, include that in your patch.

There are suggestions I could make about these two, but they're minor
and arguably a matter of personal preference.

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

A government exists to serve its citizens, not to control them.