[Mplayer-cvslog] CVS: main/libmpdemux demux_mkv.c, 1.14, 1.15 demux_ogg.c, 1.51, 1.52

[Attila Kinali]

On Wed, Jul 21, 2004 at 11:37:30PM +0300, Ivan Kalvachev wrote:
> attila said:
> >>  #ifdef USE_ICONV
> >> -  subcp_open();
> >> +  subcp_open_noenca();
> >>  #endif
> >
> > Hmm ? This looks very bogous. I can currently not chekc what
> > ENCA is (writting this mail offline) but it's definitly not
> > iconv.
> > Please either state why ENCA is iconv or reverse this change.
> >
> > 			Attila Kinali
> Enca is a library that is trying to guess the codepage by knowing the country
> and having a sample from the text.
> subcp_open_noenca() simply parse the subcp command line parameter and pass it
> to subcp_open(char *), that now takes an codepage as parameter.
> Yeh i agree that it looks like cosmetic change, but I guess it is too late
> already:(

That wasnt what i meant. The patch changes the call of the init
function from iconv to enca without changing the #ifdef.
ie i suspect that it breaks iconv if enca isnt installed.

IMHO it should be rather something like 

#ifdev USE_ICONV
#ifdev HAVE_ENCA
	subcp_open_noenca();
#elseif
	subcp_open();
#endif
#endif

or am i mistaken ?


			Attila Kinali