[Mplayer-cvslog] CVS: main cfg-mplayer.h,1.214,1.215

[Diego Biurrun]

Sascha Sommer CVS writes:
 > Modified Files:
 > 	cfg-mplayer.h 
 > Log Message:
 > adapter selection patch by Rune <runner at mail.tele.dk> +first
 > attempt to implement 2 window fullscreenswitching by me
 > 
 > --- cfg-mplayer.h	5 Feb 2004 17:08:55 -0000	1.214
 > +++ cfg-mplayer.h	29 Feb 2004 20:33:07 -0000	1.215
 > -
 > +	

You've added a spurious tab here, btw..

 > +#ifdef HAVE_DIRECTX
 > +    {"adapter", &adapter_num, CONF_TYPE_INT, CONF_RANGE, 0, 5, NULL},
 > +    {"refreshrate",&refresh_rate,CONF_TYPE_INT,CONF_RANGE, 0,100, NULL},
 > +#endif

This is bad syntax IMNSHO.  VO specific stuff should not be
implemented as a global option, but as a suboption of the vo driver.
This is current MPlayer policy AFAICT.

  mplayer -vo directx:1:75 movie.nut

would be so much better than

  mplayer -vo directx -adapter 1 -refreshrate 75 movie.mkv

Diego