[Mplayer-cvslog] CVS: main cfg-common.h, 1.131, 1.132 cfg-mencoder.h, 1.84, 1.85 cfg-mplayer.h, 1.218, 1.219

[Diego Biurrun]

The Wanderer writes:
> Diego Biurrun CVS wrote:
> > -	{"csslib", "libcss support is OBSOLETED! RTFM!\n", CONF_TYPE_PRINT, CONF_NOCFG, 0, 0, NULL},
> > +	{"csslib", "libcss support is obsolete. Try libdvdread instead.\n", CONF_TYPE_PRINT, CONF_NOCFG, 0, 0, NULL},

> Any particular reason why the third of these does not remove the word 
> "support", as the others do?

None at all, it's a bug.

> > -	// select audio/videosubtitle stream
> > +	// select audio/video subtitle stream
> >  	{"aid", &audio_id, CONF_TYPE_INT, CONF_RANGE, 0, 8190, NULL},
> >  	{"vid", &video_id, CONF_TYPE_INT, CONF_RANGE, 0, 8190, NULL},
> >  	{"sid", &dvdsub_id, CONF_TYPE_INT, CONF_RANGE, 0, 8190, NULL},
> 
> Incorrect - the inserted space should have been a slash.

yep

> > -	{"tsfastparse", "-tsfastparse isn't a valid option anymore.\n", CONF_TYPE_PRINT, CONF_NOCFG ,0,0, NULL
> > +	{"tsfastparse", "-tsfastparse is not a valid option anymore.\n", CONF_TYPE_PRINT, CONF_NOCFG ,0,0, NULL
> 
> Suggest "is no longer a valid option". This could be a matter of taste.

good suggestion

> > -/* from dec_audio, currently used for ac3surround decoder only */
> > +/* from dec_audio, currently used for AC3 surround decoder only */
> 
> Are you sure this isn't a reference to a decoder called "ac3surround"?

No, I'm not, so I'll give the original the benefit of the doubt and
change it back.  Seems like you are right.

> > -	// set output framerate - recommended for variable fps (.asf etc) files
> > -	// and for 29.97fps progressive mpeg2 streams
> > +	// set output framerate - recommended for variable fps (ASF etc) files
> > +	// and for 29.97fps progressive MPEG2 streams
> 
> Technically this should be "variable-FPS". That's a nitpick, though.

OK, we have fps instead of FPS throughout the whole docs, though.

All fixed, thanks.

Diego