[Mplayer-cvslog] CVS: main ChangeLog,1.101,1.102

[Diego Biurrun]

The Wanderer writes:
> Diego Biurrun CVS wrote:
> > -    * support for the XviD and DivX4/5linux libraries at the same time
> > +    * support for the XviD and DivX4/5Linux libraries at the same time
> 
> I don't think the L in "DivX4linux" is supposed to be capitalized.

Hmm.  I'm not 100% sure, but it's written this way throughout most of
the documentation.  Looking around the web I find it written either
completely lowercase or capitalized like that.

> > -    * some -fixed-vo and vo_preinit fixes, -vo sdl,xmga,mga should work...
> > +    * some -fixed-vo and vo_preinit fixes, -vo sdl, xmga, mga should work...
> 
> I think it's possible that the spaces between the VO methods were
> omitted intentionally - that is the format used in the config file. This
> one appears in at least one other location, as well, which I'll point
> out if I notice it.

Heh, you are right, this even was a fix for a bug I had reported, mga
would not uninit cleanly.

> > -    * Fixed a bug in MMX optimized mp3lib (triggered by OpenBSD)
> > +    * Fixed a bug in MMX optimized mp3lib (triggered by OpenBSD).
> 
> "MMX-optimized" is being used as an adjective, and so needs a hyphen.

Fixed everywhere.

> > -    * preferences: Screensaver, Autosync settings
> > +    * preferences: screensaver, Autosync settings
> 
> Just in case: is there a reason why "Autosync" was left capitalized?

Yes, it's written like that in the GUI.

> > -    * some .mp3 playback/seek segfaults fixed
> > +    * some .MP3 playback/seek segfaults fixed
> 
> Inconsistent with other fixes - in most places, you converted ".mp3" to
> "MP3", but here you left the dot in place.

That was an oversight, thx.

> > -    * various small bugfixes, endianess fixes
> > +    * various small bug fixes, endianess fixes
> 
> Sure that isn't "endianness"?

It is, fixed.

> I'm not sure "bugfix" doesn't qualify as a single word.

A bit more than bug report, yes. That's one thing I am unsure about in
English.  Are there definitive rules when and what to write as a
single or two words?

> > -    * -vop 2xsai - 2x scaler for drawn images (low color cartoon anims)
> > +    * -vop 2xsai - 2x scaler for drawn images (low color cartoon animations)
> 
> "low color" should I think be "low-color".

OK

> > -    * low FPS .wmv playback fixed
> > +    * low FPS WMV playback fixed
> 
> "low FPS" should be "low-FPS" - phrase as adjective again.

OK

> > -    * includes libmpdvdkit - patched kit of DVD libraries (enabled for linux+freebsd)
> > +    * includes libmpdvdkit - patched kit of DVD libs (enabled for Linux+FreeBSD)
> 
> In other places, you've expanded short forms ("anims" to "animations",
> for instance), but here you go the other direction (turning "libraries"
> into "libs"). Any reason for this?

Yes, to make the line fit on an 80 character display.

> > -    * support for more fileformats, including the new and very popular .ogg
> > +    * support for more fileformats, including the new and very popular Ogg
> 
> Elsewhere (above, in the pre8 section), you change "fileformat" to "file
> format"; here and elsewhere, you leave it alone despite changing other
> things on the same line. Which is correct?

It's an oversight, file format.

> > -    * minor bugfixes for realmedia/nuppelvideo demuxers
> > +    * minor bug fixes for realmedia/nuppelvideo demuxers
> 
> Shouldn't that be "RealMedia"?

yes

All suggestions followed, thanks.

Diego