[Mplayer-cvslog] CVS: main/libmpdemux demux_ogg.c,1.49,1.50

[The Wanderer]

Moritz Bunkus wrote:

> Hi,
> 
>> Suggest
>> 
>> "Ogg demuxer: Stream ID %d matched -slang %s\n"
> 
> No, it doesn't mention that it's a subtitle stream. Both messages are
> supposed to be nearly the same.

Acknowledged - I think I misphrased this when suggesting it before.

>> "Ogg demuxer: Displaying subtitle stream %d, which matched -slang %s\n"
>> 
>> because the new form looks toe verbose to me,
> 
> This is printed at MSGL_V, so it's supposed to be verbose. Anyway,
> this version can be understood at a glance (unlike your first
> proposal).

There's still no need to be unnecessarily verbose, <grin> Point taken,
however, and thank you for removing the comma.

>> This line also has an indentation change, which may or may not have
>> been intentional.
> 
> It changes tabs to spaces, but not the indentation.

Um... in the diff sent, the line with the + was indented one space
farther than the line with the - (or the other line in the same {}
block). To me, that says an indentation change.

...Hmm. That would be because the line above still has a tab; the
difference is invisible in the actual source file, just not in the mail.
My mistake.

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

A government exists to serve its citizens, not to control them.