[Mplayer-cvslog] CVS: main/libaf af_lavcresample.c,1.2,1.3

[D Richard Felker III]

On Sun, Nov 07, 2004 at 05:04:38PM +0200, Ivan Kalvachev wrote:
> On Sun, 7 Nov 2004 14:39:40 +0100
> Alex Beregszaszi <alex at fsn.hu> wrote:
> 
> > Hi,
> > 
> > > > > I would like to have rational.[ch] code in MPlayer as it
> > > > > could be used not only by lavc related codecs (but also from x264,
> > > > > xvid etc..).
> > > > >
> > > > > As it is your code, I would be happy if you commit it here too. I
> > > > > know you like GPL more than LGPL :)
> > > > 
> > > > iam against code/file duplication
> > > 
> > > I need this code even if lavc is not compiled in MPlayer.
> > 
> > Never ever try doing this. We are working on removing duplicates since
> > ages, why are doing the opposite? Compiling mplayer without lavc has no
> > sense.
> > 
> > I'm strongly against this.
> 
> I would accept solution where configure checks for libavcodec and dies
> with fatal error message if it is not present.
> Until then we should handle the case that user may not want libavcodec.

agree with both points.

rich