[MPlayer-cvslog] CVS: main/libmpcodecs vd_libmpeg2.c,1.37,1.38

D Richard Felker III dalias at aerifal.cx
Tue Nov 23 22:55:08 CET 2004


On Tue, Nov 23, 2004 at 06:59:36PM +0100, Jindrich Makovicka wrote:
> Michael Niedermayer wrote:
> >vd_ffmpeg certainly didnt need either width or height to be a multiple of 
> >8, if it does now someone broke it
> 
> i wanted to write 16, but it doesn't actually matter. the segfault 
> doesn't occur in directly ffmpeg, but the image created with
> 
>  mpi= mpcodecs_get_image(sh,type, flags,
>                         (width+align)&(~align), (height+align)&(~align));
> 
> can eventually propagate to a VO previously configured to width x 
> height, which blows up then. to correct the things, mpi should be 
> allocated with the physical dimensions according to the alignment, while 
> logical dimensions mpi->w and mpi->h should be equal to width and 
> height. however, this is impossible with current vf api.

hmm, looks like something is just broken and mixing up w/h versus
width/height versus stride...

rich




More information about the MPlayer-cvslog mailing list