[Mplayer-cvslog] CVS: main/libmpcodecs vd_xvid4.c,1.2,1.3

[Diego Biurrun]

Reimar Döffinger writes:
> 
> >>Renames xvid_ini to xvid_gbl_init and dec_p to xvid_dec_create
> >>That'll make the move to 1.1.x front-end smoother.
> > 
> > WHAT THE HELL ARE YOU TALKING ABOUT????!!!
> > 
> > THIS COMMIT IS PURE COSMETIC, I DON"T SEE ANY FUNCTIONAL CHANGE.
> > IT IS NOT POSSIBLE TO IMPROVE ANYTHING!!!
> > 
> > Revert immediately
> 
> In his defense: he asked about that several times and got no reply 
> except from me that I personally don't like it.
> As I understood it he didn't want to modify the other patch too much as 
> he doesn't understand it too well. And committing a patch that contains 
> both cosmetics and code changes is even more unacceptable.
> So tell him how to do it and I have the impression he will do it. I'm 
> currently too confused by all these discussions that I can't give clear 
> advice...

Also in his defense: Ivan, you are not listed in the MAINTAINERS file
as the XviD maintainer, so it is pretty hard to tell for a newcomer
that XviD has a maintainer at all or that it could be you.

Guillaume is not subscribed to -cvslog.  Guillaume, this is something
you have to do.  It's also written in cvs-howto.txt.  If you commit
things you have to be available to fix your mistakes.

Diego