[Mplayer-cvslog] CVS: main/libmpcodecs vd_xvid4.c,1.2,1.3

[Reimar Döffinger]

Hi,

>> Now try to guess how hard it is to find the thing that caused it to 
>> break when the patch consists of hundreds of changed lines but most of 
>> them are only cosmetics. You would have to check each of those whether 
>> they changed something or not.
> 
> Cosmetic only patches are easy to verify:
>    cmp old.o new.o ;

Please read again. "consists of hundreds of changed lines but most of 
them are only cosmetics". How does comparing the object files help me? 
And with pure cosmetics the log message _must_ indicate that anyway. So 
your suggestion doesn't help anything.
And as far as readability is concerned I have admit that some parts a 
really bad but:
1) I'm not sure that e.g. changing only intendation would help that. 
Adding comments in some places would help far more.
2) When people reformat the code so that they can easily read it I quite 
often find it just as unreadable as before.
3) Find some indent parameters that suit you should help in most cases. 
Nobody forbids you to do cosmetics in your local tree...

Greetings,
Reimar Döffinger