[Mplayer-cvslog] CVS: main/libmpcodecs vd_xvid4.c, 1.2, 1.3 FORWARD

[The Wanderer]

Arpi wrote:

>> The only rule my module breaks is rule 4. And that's the only
>> reminder:
> 
> 4. Do not change behavior of the program (renaming options etc)
> without first discussing it on the mplayer-dev-eng mailing list. Do
> not remove functionality from the code. Just improve!
> 
> wtf? how is rule 4 related to the rejected cosmetics commit??? he
> renamed the variables (in the code, invisible to users), not the
> options!

I think he was referring to rule 4 in patches.txt, not to rule 4 in
cvs-howto.txt. The content of the former is in fact appropriate.

(Rule 6 in cvs-howto.txt would in fact constitute another reminder, but
that's a different issue.)

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

A government exists to serve its citizens, not to control them.