[Mplayer-cvslog] CVS: main/libmpcodecs vd_xvid4.c,1.2,1.3

[Alexander Strasser]

Guillaume Poirier wrote ( On Thu, Oct 07, 2004 at 01:43:23PM +0200 ):
> Alexander Strasser wrote:
> 
> >So there are to possibilities:
> >
> >I.  Making the mplayer specific de/encoder files for XviD externally 
> >maintained.
> >    --> reverting the commits and sync to external source
> >II: Go on with our own development of these file
> >    --> reverting commits and wait until someone sends patches that get 
> >    accepted
> 
> I'd prefer the 2nd solution. That way we get over all cosmetics issues, 
> and make clear that Edouard's code is valuable to us.
> I know my commit should never had happen in the first place, but at 
> least it allowed the all of us to discuss the future of that piece of 
> code, which is good.
> 
> The "nice" thing about the solution you bring up is that it doesn't 
> revert too many commits (9 for the encoder, and 3 for the decoder, which 
> doen't seem much)

Sorry, i seem to have expressed my suggestions of the actions that can be
taken ( the stuff after -->  ) in an unclear way, so next try:

I.  Making the mplayer specific de/encoder files for XviD externally
    maintained.
    --> my suggestion in this case is to revert the commit and make
        the transitions in one commit, but as i understand this way
        of doing it is discussable. We could also go further with
        your splitted up way of making the transition to be in sync
        with GomGom's source. So for further discussion, are you
        done with all patches needed for a more or less smooth
        transition?

II. Go on with our own development of these file
    --> this way imposes a revert as we have to wait in this case
        for someone, maybe you guillaume, to send patches that
        get accepted by the maintainer iive.

  Alex (beastd)