[Mplayer-cvslog] CVS: main/libmpcodecs vd_xvid4.c,1.2,1.3

[Diego Biurrun]

Moritz Bunkus writes:
> 
> > II. Go on with our own development of these file
> 
> We don't. Develop it, that is. The log for ve_xvid4.c:
> 
> revision 1.9
> date: 2004/10/01 22:53:14;  author: gpoirier;  state: Exp;  lines: +76 -79
> Moves around some functions, which makes the code clearer (it groups
> helper functions together) is one step closer to a nice 1.1 front-end.
> ----------------------------
> revision 1.8
> date: 2004/07/13 18:09:58;  author: iive;  state: Exp;  lines: +2 -2
> 10l fixed_quant reciprocal fix by Michael Neuhauser
> <mike_at_firmix_dot_at>
> ----------------------------
> revision 1.7
> date: 2004/03/24 15:16:36;  author: ranma;  state: Exp;  lines: +1 -0
> Use aspect from encoder for AVI vprp header
> ----------------------------
> revision 1.6
> date: 2004/02/06 23:45:53;  author: iive;  state: Exp;  lines: +7 -9
> allow using of float fixed_quant
> 
> So if someone actually cares about it (Edouard does) and codes for it
> (Edouard does) then we should welcome his work with open arms. If he
> maintains nearly identical modules in different products (which he does,
> mplayer and transcode) then maintenance should be as easy for him as
> possible. Fewer mistakes, more productive work.
> 
> So I strongly vote for declaring it "externally maintained" and applying
> patches that will turn it into Edouard's version.
> 
> > I.  Making the mplayer specific de/encoder files for XviD externally
> >     maintained.
> >     --> my suggestion in this case is to revert the commit and make
> >         the transitions in one commit, but as i understand this way
> >         of doing it is discussable.
> 
> I don't see the point in reverting it. ve_xvid4.c should end up being
> Edouard's code. It doesn't really matter if this is one big commit or
> several ones that include "cosmetics".

I strongly agree with both of your points and was in fact about to
compose a similar mail.

Diego