[Mplayer-cvslog] CVS: main/libmpcodecs vd_xvid4.c,1.2,1.3

[Alexander Strasser]

Guillaume POIRIER wrote ( On Thu, Oct 07, 2004 at 05:42:30PM +0200 ):
> Hi,
> Le jeu 07/10/2004 à 14:44, Alexander Strasser a écrit :
> 
> > Sorry, i seem to have expressed my suggestions of the actions that can be
> > taken ( the stuff after -->  ) in an unclear way, so next try:
> > 
> > I.  Making the mplayer specific de/encoder files for XviD externally
> >     maintained.
> >     --> my suggestion in this case is to revert the commit and make
> >         the transitions in one commit, but as i understand this way
> >         of doing it is discussable. We could also go further with
> >         your splitted up way of making the transition to be in sync
> >         with GomGom's source. So for further discussion, are you
> >         done with all patches needed for a more or less smooth
> >         transition?
> 
> Yes, the second half of patchsets to make the transition to 1.1.x has
> been posted to the mailling list, I believe the same day as I committed
> my cosmetics. Reimar gave me feedbacks on it, so I re-worked them, and
> posted a cleaner version.
> So if you take my latest patchset and apply it to the sourcetree, you'll
> get 90% of Edouard front-end, with the exception of a structure name
> that I left with the previous "MEncoder name", not Edouard's.
> Eventually, this could be fixed with another patch after the other one
> will get applied.

IMHO we should make it identical, so going with your patches might
be more work. But let's wait what others have to say about it, Mosu is
for going on applying your patches and Diego too.

> > II. Go on with our own development of these file
> >     --> this way imposes a revert as we have to wait in this case
> >         for someone, maybe you guillaume, to send patches that
> >         get accepted by the maintainer iive.
> 
> Even though I could do it, it'll require me more time to understand the
> code, and break the changes in smaller pieces. This solution is more
> prone to errors than taking the rock-solid code of Edouard.
> Plus, as I said many times, I do think it'll be good to shake hands with
> the XviD team, and this 2nd solution isn't going in that direction.

I'm too not for this solution as I said in reply to Mosu's mail a few
hours ago.

So let's at least wait for Ivans oppinion as he took care of the code so far.

  Alex (beastd)