[Mplayer-cvslog] CVS: main/libmpcodecs vd_xvid4.c,1.2,1.3

[Felix Buenemann]

On Saturday 09 October 2004 14:17, Ivan Kalvachev wrote:
> In the decoder vd_xvid4.c, he change the init function of the video system,
> so he can pass the aspect information. I still haven't reviewed that code,
> but for me it looks risky and could have some possible itches with e.g.
> direct rendering (that's off by default). The problem is that e.g. lavcodec
> use an callback functions (get_buffer, get_format..) so we could init the
> video system in it. XviD have only decoder function. As I said It involves
> a lot of code and should be checked carefully, something I didn't had time
> to do.
Right way would be to pass aspect ration information (on decoding) to mplayer 
core so the aspect code can take care of it (just like libmpeg12 and lavc do 
it).
-- 
Best Regards,
        Atmos
____________________________________________
- MPlayer Developer - http://mplayerhq.hu/ -
____________________________________________