[Mplayer-cvslog] CVS: main/libvo vo_gl.c,1.45,1.46

[Joey Parrish]

On Wed, Sep 01, 2004 at 01:54:01AM +0200, Michael Niedermayer wrote:
> Hi
> 
> On Tuesday 31 August 2004 22:52, Dominik 'Rathann' Mierzejewski wrote:
> > On Monday, 30 August 2004 at 21:35, Reimar Döffinger wrote:
> > > Hi,
> > >
> > > > Modified Files:
> > > > 	vo_gl.c
> > > > Log Message:
> > > > small gcc warning fixes
> > >
> > > I'm the maintainer for this code, please don't change it without asking!
> >
> > Sorry, won't happen again.
> >
> > > > -        char *parse_pos = &arg[0];
> > > > +        char *parse_pos = (char *)&arg[0];
> > >
> > > I'm not sure if I like this brute-force approach for removing warnings,
> > > not to mention that I find it useless.
> >
> > How else do you propose to fix the "assignment from incompatible pointer
> > type" warning?
> ignore it?
> 
> or 
> 
> -char *parse_pos = &arg[0];
> +const char *parse_pos = &arg[0];

Agree.  Not every compiler warning is serious.  That's why they are
simply warnings.  Yes, many point to problematic code or code that
should be closely examined... but I doubt that this is one of them.

--Joey

-- 
"The greatest thing you'll ever learn
is just to love and be loved in return." -- Darth Vader