[Mplayer-cvslog] CVS: main m_config.h,1.5,1.6

D Richard Felker III dalias at aerifal.cx
Thu Sep 2 01:55:49 CEST 2004


On Mon, Aug 30, 2004 at 07:36:50PM +0200, Reimar Döffinger CVS wrote:
> CVS change done by Reimar Döffinger CVS
> 
> Update of /cvsroot/mplayer/main
> In directory mail:/var2/tmp/cvs-serv9552
> 
> Modified Files:
> 	m_config.h 
> Log Message:
> aligning m_config_save_slot.data, necessary for SPARC64
> 
> 
> Index: m_config.h
> ===================================================================
> RCS file: /cvsroot/mplayer/main/m_config.h,v
> retrieving revision 1.5
> retrieving revision 1.6
> diff -u -r1.5 -r1.6
> --- m_config.h	13 Aug 2003 16:29:00 -0000	1.5
> +++ m_config.h	30 Aug 2004 17:36:48 -0000	1.6
> @@ -9,6 +9,9 @@
>  struct m_config_save_slot {
>    m_config_save_slot_t* prev;
>    int lvl;
> +  // we have to store other datatypes in this as well,
> +  // so make sure we get properly aligned addresses
> +  __attribute__ ((aligned (8)))
>    unsigned char data[0];
>  };

reversed, this is utter nonsense and does not compile:
m_config.h:14: parse error before `__attribute__'
m_config.h:14: warning: no semicolon at end of struct or union

if you want to align data, then the align attribute should be on data,
not floating by itself in the middle of the structure...

rich




More information about the MPlayer-cvslog mailing list