[Mplayer-cvslog] CVS: main configure,1.910,1.911

[The Wanderer]

Sascha Sommer CVS wrote:

> @@ -4277,7 +4277,7 @@
>  int main(void) { JACK_Init(); return 0; }
>  EOF
>          # This test only checks the minor version number.
> -        if ( ( test ! `bio2jack-config --version | cut -d '.' -f 2` -ge 2 ) ) ; then
> +        if ( ( test ! `bio2jack-config --version | cut -d '.' -f 2` -ge 3 ) ) ; then
>  	    _jack=no;
>  	elif test -z "$_bio2jackdir" ; then
>  		cc_check -lbio2jack `pkg-config --libs --cflags jack` && ( "$TMPO" >> "$TMPLOG" 2>&1 ) && _jack=yes

I'll take this opportunity to mention that there appears to be something
wrong in this code. With any of the other configure tests, whether they
fail or succeed, I don't see any of the output of the intermediate
commands; I just see "yes" or "no". With the JACK detection test, I see:

Checking for JACK ... ./configure: line 1: bio2jack-config: command not
found
./configure: line 4280: test: !: integer expression expected
no

I don't have bio2jack installed, and don't know where to get it (and
apparently don't really care, since I haven't bothered to Google), as a
result of which bio2jack-config does not exist on my system. Anyone who
does not have the library installed probably will not have the config
program installed either.

This output has been present for some while (possibly ever since the
detection was committed in the first place), and seems rather incorrect,
but I don't know nearly enough about shell scripting to figure out what
to do to correct it. ("if [ -a `which bio2jack-config` ]", maybe? no,
that doesn't work...)

-- 
       The Wanderer feels incompetent

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

A government exists to serve its citizens, not to control them.