[Mplayer-cvslog] CVS: main configure,1.910,1.911

[Alexander Strasser]

Joey Parrish wrote ( On Wed, Sep 15, 2004 at 04:46:55PM -0500 ):
> On Wed, Sep 15, 2004 at 11:20:42PM +0000, Sascha Sommer wrote:
> > > I'll take this opportunity to mention that there appears to be something
> > > wrong in this code. With any of the other configure tests, whether they
> > > fail or succeed, I don't see any of the output of the intermediate
> > > commands; I just see "yes" or "no". With the JACK detection test, I see:
> > >
> > > Checking for JACK ... ./configure: line 1: bio2jack-config: command not
> > > found
> > > ./configure: line 4280: test: !: integer expression expected
> > > no
> > >
> > > I don't have bio2jack installed, and don't know where to get it (and
> > > apparently don't really care, since I haven't bothered to Google), as a
> > > result of which bio2jack-config does not exist on my system. Anyone who
> > > does not have the library installed probably will not have the config
> > > program installed either.
> > >
> > > This output has been present for some while (possibly ever since the
> > > detection was committed in the first place), and seems rather incorrect,
> > > but I don't know nearly enough about shell scripting to figure out what
> > > to do to correct it. ("if [ -a `which bio2jack-config` ]", maybe? no,
> > > that doesn't work...)
> > 
> > I don't have this file installed either and there is no such failure.
> > What about         if ( ( test not `bio2jack-config --version | cut -d '.' -f 
> > 2` -ge 3 ) ) ; then
> > 
> > No idea. I'm not really an expert when it comes to shell scripting...
> 
> It's simple.  Current CVS has:
> 
> - if ( ( test ! `bio2jack-config --version | cut -d '.' -f 2` -ge 3 ) ) ; then
> 
> Redirect bio2jack-config's stderr to /dev/null and that takes care of
> error messages if it doesn't exist.  Change it to:
> 
> + if ( ( test ! `bio2jack-config --version 2>/dev/null | cut -d '.' -f 2` -ge 3 ) ) ; then

Didn't work for me.
What do you think about this:
if ( ( test `bio2jack-config --version | cut -d '.' -f 2` -ge 3 ) ) >/dev/null 2>&1 ; then

  Alex (beastd)