[Mplayer-cvslog] CVS: main mplayer.c,1.786,1.787

[D Richard Felker III]

On Thu, Sep 16, 2004 at 06:36:03PM +0000, Sascha Sommer wrote:
> On Thursday 16 September 2004 16:06, D Richard Felker III wrote:
> > On Thu, Sep 16, 2004 at 11:25:59AM +0200, Sascha Sommer CVS wrote:
> > > CVS change done by Sascha Sommer CVS
> > >
> > > Update of /cvsroot/mplayer/main
> > > In directory mail:/var2/tmp/cvs-serv30172
> > >
> > > Modified Files:
> > > 	mplayer.c
> > > Log Message:
> > > make it possible to use the run command from a menu config file, based on
> > > a patch by Aurelien Jacobs <aurel at gnuage.org>
> > >
> > > Index: mplayer.c
> > > ===================================================================
> > > RCS file: /cvsroot/mplayer/main/mplayer.c,v
> > > retrieving revision 1.786
> > > retrieving revision 1.787
> > > diff -u -r1.786 -r1.787
> > > --- mplayer.c	15 Sep 2004 11:26:45 -0000	1.786
> > > +++ mplayer.c	16 Sep 2004 09:25:56 -0000	1.787
> > > @@ -3197,6 +3197,16 @@
> > >      case MP_CMD_GET_PERCENT_POS : {
> > >  	mp_msg(MSGT_GLOBAL,MSGL_INFO,"ANS_PERCENT_POSITION=%ld\n",
> > > demuxer_get_percent_pos(demuxer)); } break;
> > > +#ifdef HAVE_MENU
> > > +    case MP_CMD_CRUN : {
> > > +#ifndef __MINGW32__
> > > +        if(!fork()) {
> > > +          execl("/bin/sh","sh","-c",cmd->args[0].v.s,NULL);
> > > +          exit(0);
> > > +        }
> > > +#endif
> > > +    } break;
> > > +#endif
> >
> > will the children get reaped when they exit, or will zombie processes
> > hang around forever??
> >
> 
> I'm not sure what you mean. The children will run as if you started them from 
> another shell. They are completely independant from MPlayer after the start. 

no they are not! any process that spawns child processes has to wait()
for them in the sigchld handler. otherwise they will become zombies
and keep using a pid forever until the parent process dies. mplayer
may already do this, but you need to check...

rich