[Mplayer-cvslog] CVS: main configure,1.910,1.911

Diego Biurrun diego at biurrun.de
Mon Sep 20 08:54:23 CEST 2004


Alexander Strasser writes:
> 
> Tried to correct it (patch attached), the indentation is stupid but I don't
> want to mix up with cosmetics as this always lead to trouble in the past...

Please fix the indentation nevertheless, in a second commit should you
prefer, but you sent a patch without indentation changes for review,
so..

> so here is my fix, please look over it. But I think I got it right now.

I stared long and hard at it and cannot spot any mistakes, commit.

> +    if ( ( test `bio2jack-config --version | cut -d '.' -f 2` -ge 3 ) ) >/dev/null 2>&1 ; then

Nitpickish me would add a space between ">" and "/dev/null" for better
readability and added consistency.

Diego




More information about the MPlayer-cvslog mailing list