[Mplayer-cvslog] CVS: main/libfaad2 mdct_tab.h, NONE, 1.1 neaacdec.h, NONE, 1.1 ps_dec.c, NONE, 1.1 ps_dec.h, NONE, 1.1 ps_syntax.c, NONE, 1.1 ps_tables.h, NONE, 1.1 Makefile, 1.4, 1.5 README, 1.2, 1.3 cfft.c, 1.4, 1.5 common.c, 1.4, 1.5 common.h, 1.

[D Richard Felker III]

On Mon, Sep 27, 2004 at 07:59:24AM +0200, Arpi wrote:
> Hi,
> 
> > > Log Message:
> > > Update FAAD to a 2.1 beta CVS snapshot from 2004.07.12.
> > > patch by adland <adland123 at yahoo dot com>
> > 
> > arrg! this is the new all-time cola record, with
> > 100000000000000000000l!
> 
> where do you want your cola "donation" to be shipped?
> 
> http://mplayerhq.hu/~arpi/eu2004/mplayer/2560/p8151391-10000l.jpg

:))))))))))))))))
that even beats mplayer-india.jpg!

> > diego, please either find the cause of this and fix it ASAP, or
> > reverse this stupid nonsense! and from now on don't commit code unless
> > you're willing to be a coder and test it...
> 
> agree

we discussed it on irc and i apologized. actually the code _is_ broken
like i claimed, but the insane slowness isn't visible unless you add
-DFIXED_POINT (well actually it's always insanely slow without that,
so the difference between versions is only visible with
-DFIXED_POINT). to be fair, diego _had_ extensively tested the version
he committed with normal settings, he just didn't realize it could be
non-slow if you define FIXED_POINT... :)

rich