[Mplayer-cvslog] CVS: main/DOCS/tech slave.txt,1.19,1.20

[Sascha Sommer]

On Saturday 25 September 2004 02:06, Attila Kinali wrote:
> On Sun, Sep 19, 2004 at 08:36:21PM +0200, Sascha Sommer CVS wrote:
> >  switch_ratio [<value>]
> >      Change aspect ratio at runtime. Value is the new aspect ratio
> > expressed as a float (e.g. 1.77778 for 16/9).
> > +    There might be problems with some video filters.
>
> Is this really just a vf prob ? Can't it also happen with some vos ?
>
> IMHO there is one problem anyways: some vo's do some additional settings
> based on the aspect when config() is called. One that comes to my mind
> are the x11 based modules which set the window aspect (if -keepaspect,
> which is default). This is never reset (see also my mail about
> vo_x11_sizehint on -dev-eng for other problems caused by this).
> IMHO this calls for an other VCTRL (something like VCTRL_ASPECT),
> but then again, the behaviour of the vo layer is IMHO outdated anyways
> and needs some redesign.
>

Of course there might be problems, nevertheless I didn't have any with -vo xv 
and anyway, this is not meant to be the general, all purpose aspect switching 
code, but a simple solution to do some corrections, especially when used with 
Geexbox.
Btw. -fixed-vo requires the vos to be reconfigured without uniniting them 
first, so the vos having problems should be fixed then.
Imho all this window handling and aspect stuff does not belong directly into
the individual vos. They should only export their buffers and display the 
image on a given x, y, width, height and colorkey like in g2.

Sascha