[MPlayer-cvslog] CVS: main/etc codecs.conf,1.405,1.406

Jindrich Makovicka makovick at kmlinux.fjfi.cvut.cz
Sat Apr 9 01:06:59 CEST 2005


Roberto Togni wrote:
> On Fri, 8 Apr 2005 15:41:55 -0400
> D Richard Felker III <dalias at aerifal.cx> wrote:
> [...]
> 
>>>AFAIK, flip is broken and deprecated. If all BGR24 videos are really
>>>flipped, libavcodec should be fixed instead, somehow like this.
>>
>>Indeed it's broken. stride should just be negative if the video is
>>flipped.
> 
> 
> What do you mean exactly?
> flip is mostly used for binary codec, where we can't modify the way
> image is coded; it's used also by native codecs for some variations of
> mpeg4 and h263, and lzo.
> Used mainly for rgb, but on a few cases also for yuv.

I meanwhile found that memcpy_pic didn't handle negative strides, which
screwed things when flip was used. So now flip should be less broken
than before :)

-- 
Jindrich Makovicka




More information about the MPlayer-cvslog mailing list