[MPlayer-cvslog] CVS: main mencoder.c,1.278,1.279

Dominik 'Rathann' Mierzejewski dominik at rangers.eu.org
Sun Apr 10 22:16:58 CEST 2005


On Thursday, 07 April 2005 at 23:18, Diego Biurrun wrote:
> On Wed, Apr 06, 2005 at 06:46:03PM +0200, Dominik 'Rathann' Mierzejewski wrote:
> > On Wednesday, 06 April 2005 at 15:19, Diego Biurrun wrote:
> > 
> > > Granted, the CVS policy is ambiguous about this, but I never interpreted it
> > > to forbid this kind of changes, have you?  Why do you oppose this?
> > 
> > ...the CVS policy is "do not mix cosmetic changes with functional changes".
> > So, to follow it to the letter, you'd make two commits instead of one.
> 
> My interpretation of the above sentence is: Don't commit something where
> one hunk is just cosmetic indentation changes and another is functional
> changes.  I never interpreted it to forbid reindenting a line that is
> being changed anyway.

I thought reindenting was forbidden anyway, but - do as you will, it's
not my code to complain about. ;)

Regards,
R.

-- 
MPlayer RPMs maintainer: http://rpm.greysector.net/mplayer/
"I am Grey. I stand between the candle and the star. We are Grey.
 We stand between the darkness ... and the light."
        -- Delenn in Grey Council in Babylon 5:"Babylon Squared"




More information about the MPlayer-cvslog mailing list