[MPlayer-cvslog] CVS: main/libvo vo_gl.c,1.66,1.67

[Jindrich Makovicka]

Reimar Döffinger wrote:
> Hi,
> On Sun, Apr 10, 2005 at 08:53:55PM +0200, Jindrich Makovicka wrote:
> 
>>Reimar Döffinger wrote:
>>
>>>On Sun, Apr 10, 2005 at 03:12:58PM +0200, Jindrich Makovicka CVS wrote:
>>>
>>>>Log Message:
>>>>revert the previous commit, gl needs to reload the font immediately
>>>
>>>I don't think so. You only have to move the vo_osd_changed part, too (I
>>>actually wonder why it is called when there is no freetype support).
>>>After all, if you take it seriously a different font (size) is a changed
>>>OSD, too...
>>>Though I have to admit this is an untested theory so far *g*
>>
>>vo_gl doesn't like oversized OSD elements and crashes when switching
>>back from fullscreen, at least on my machine. there is either a bug in
>>vo_gl OSD implementation, or nVidia is to blame. with this patch it
>>works fine.
> 
> 
> I can't reproduce the error - not even when commenting out the
> vo_osd_changed thing, too (but it will keep the old OSD size until the
> OSD changes).

Yes, because vo_gl doesn't call draw_text on each frame, but only on
each OSD change. So I think it is reasonable that it forces the font
update sooner.

> If you can, give me a gdb backtrace.
> But another thing, I think the font must also be reloaded when
> subtitle_autoscale == 1, not only when 2 or 3 (see also font_load_ft.c,
> lines 975ff).

Yes, you are right, it's necessary for vo_gl, too.

-- 
Jindrich Makovicka