[MPlayer-cvslog] CVS: main/libmpcodecs ve_x264.c,1.23,1.24

Ivan Kalvachev ivan at cacad.com
Thu Apr 14 00:00:58 CEST 2005


On Thu, 14 Apr 2005 00:14:41 +0200
Diego Biurrun <diego at biurrun.de> wrote:

> On Wed, Apr 13, 2005 at 10:13:09PM +0300, Ivan Kalvachev wrote:
> > There is rule in mplayer never to remove an option or functionality,#
> > no matter how useless it is.
> 
> There is no such rule, never has been.
> 
> DOCS/tech/cvs-howto.txt states
> 
> "Do not remove functionality from the code. Just improve!"
> 
> Useless things, bad options and deprecated features have been removed
> from MPlayer in the past and will be removed in the future.
> 
> Maybe it's time to clarify that portion of the policy, though.

Diego, can't you read or you just like arguing with me?
Oh, I get it, it does say what I say, so we have to change the rule. Great thinking.

Anyway I agree that useless is not the right word I should have used.
Probably "less likely to be used" would have been more exact.

This functionality may be useful in e.g. tracing error in the bit stream writer.
If it is exported by the library then there is sense of using it.
This function  is not deprecated or obsolete, at least 
not more than in the day it have been added.

If the default is always better, then update the documentation to say it.

Ivan Kalvachev
iive




More information about the MPlayer-cvslog mailing list