[MPlayer-cvslog] CVS: main/libmpdemux demux_audio.c,1.32,1.33

Reimar =?UTF8?Q?D=F6ffinger?= Reimar.Doeffinger at stud.uni-karlsruhe.de
Mon Apr 18 09:57:08 CEST 2005


Hi,
> > It's not quite as bad as before where some files would not play at all,
> > but still...
> 
> Well your code was definitely broken. Not only was it incredibly slow;
> I have a perfectly valid cbr 128kbit mp3 file that WILL NOT PLAY with
> your code due to it making up artificial mp1 headers in the middle of
> the mp3...

My problem is that I cannot see how that code could have this effect - unless the added support for mp1 and mp2 broke it??
It sure will find invalid headers, but they should be "forgotten" after seeing that it is not a mp1/mp2 file.
Concerning the high CPU usage at he beginning: This stems from brute-force scanning up to the first 30k of the file - but this is tuneable by both
modifiying the n < 30000 comparison in the loop and the MIN_MP3_HDRS define.

Greetings,
Reimar Döffinger




More information about the MPlayer-cvslog mailing list